fix: use react-router match route method #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivelazco
approved these changes
May 29, 2020
crash7
requested review from
a team,
gaston-flores and
peibol85
and removed request for
a team
This solves a bug where the route matching couldn't find the correct route when the route was using dynamic parameters (ie: /:something/blue).
crash7
force-pushed
the
fix/route-matching
branch
from
9e0733a
to
a63f3f7
Compare
|
➿ Code coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a bug where the route matching couldn't find the correct route when the
route was using dynamic parameters (ie: /:something/blue).